Merge pull request #220 from skomis-mm/missingTypeMsg

Show better error message for a missing interface parameter type
serilog · May 11, 2020 · 8bea591 · 8bea591
2 parents cc45629 + 9309608
commit 8bea591
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/src/Serilog.Settings.Configuration/Settings/Configuration/StringArgumentValue.cs b/src/Serilog.Settings.Configuration/Settings/Configuration/StringArgumentValue.cs
@@ -93,20 +93,22 @@ public object ConvertTo(Type toType, ResolutionContext resolutionContext)
                 // maybe it's the assembly-qualified type name of a concrete implementation
                 // with a default constructor
                 var type = FindType(argumentValue.Trim());
-                if (type != null)
+                if (type == null)
                 {
-                    var ctor = type.GetTypeInfo().DeclaredConstructors.FirstOrDefault(ci =>
-                    {
-                        var parameters = ci.GetParameters();
-                        return parameters.Length == 0 || parameters.All(pi => pi.HasDefaultValue);
-                    });
+                    throw new InvalidOperationException($"Type {argumentValue} was not found.");
+                }
 
-                    if (ctor == null)
-                        throw new InvalidOperationException($"A default constructor was not found on {type.FullName}.");
+                var ctor = type.GetTypeInfo().DeclaredConstructors.FirstOrDefault(ci =>
+                {
+                    var parameters = ci.GetParameters();
+                    return parameters.Length == 0 || parameters.All(pi => pi.HasDefaultValue);
+                });
 
-                    var call = ctor.GetParameters().Select(pi => pi.DefaultValue).ToArray();
-                    return ctor.Invoke(call);
-                }
+                if (ctor == null)
+                    throw new InvalidOperationException($"A default constructor was not found on {type.FullName}.");
+
+                var call = ctor.GetParameters().Select(pi => pi.DefaultValue).ToArray();
+                return ctor.Invoke(call);
             }
 
             return Convert.ChangeType(argumentValue, toType);