Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show better error message for a missing interface parameter type #220

Merged
merged 1 commit into from
May 11, 2020
Merged

Show better error message for a missing interface parameter type #220

merged 1 commit into from
May 11, 2020

Conversation

skomis-mm
Copy link
Contributor

fixes 194

nblumhardt
nblumhardt approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me; I can't think of any cases where falling through to Convert.ChangeType() would be desirable behavior, here 👍

@skomis-mm skomis-mm merged commit 8bea591 into serilog:dev May 11, 2020
@skomis-mm skomis-mm deleted the missingTypeMsg branch May 11, 2020 23:49
@nblumhardt nblumhardt mentioned this pull request Nov 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nblumhardt nblumhardt nblumhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readme.md docs don't work and throw InvalidCastException
2 participants
@skomis-mm @nblumhardt