You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, when calling ReadFrom.ConfigSection(IConfigurationSection configSection), the ConfigurationReader does not have access to the globalIConfiguration object, so it cannot access the configuration out of the given section. That makes it impossible to access, say, the ConnectionStrings ... .
In PR #144 we added a check to throw an exception when calling a config method that expects an IConfiguration from the ReadFrom.ConfigSection overload so that users don't shoot themselves in the foot.
We should probably mark ConfigurationSection(this LoggerSettingsConfiguration settingConfiguration /*, ...*/) methods as obsolete and instead provide new overloads like
Haven't had time to look at the code yet, but based on the issue that brought up the problem, I assume the exception is only thrown if the parameter doesn't have a default value?
Right now, when calling
ReadFrom.ConfigSection(IConfigurationSection configSection)
, theConfigurationReader
does not have access to the globalIConfiguration
object, so it cannot access the configuration out of the given section. That makes it impossible to access, say, theConnectionStrings
... .In PR #144 we added a check to throw an exception when calling a config method that expects an
IConfiguration
from theReadFrom.ConfigSection
overload so that users don't shoot themselves in the foot.We should probably mark
ConfigurationSection(this LoggerSettingsConfiguration settingConfiguration /*, ...*/)
methods as obsolete and instead provide new overloads likethis would store the global
IConfiguration
object and look for a section with a given name within.Does that seem to make sense ?
See #143 for more details
The text was updated successfully, but these errors were encountered: