Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new ReadFrom.Configuration(...) overloads; Marked old as obsolete (#148) #163

Merged
merged 1 commit into from
Jun 2, 2019
Merged

Added new ReadFrom.Configuration(...) overloads; Marked old as obsolete (#148) #163

merged 1 commit into from
Jun 2, 2019

Conversation

skomis-mm
Copy link
Contributor

Fixes #148

tsimbalar
tsimbalar approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@tsimbalar tsimbalar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🚀

Not sure if that change should cause a "minor" version bump to 3.1.0 ?
At least with all your changes in the last days, it's probably fair to consider it a new version with new feature and no breaking changes :)

@tsimbalar tsimbalar mentioned this pull request Mar 25, 2019
Merged
@nblumhardt nblumhardt merged commit b4adf75 into serilog:dev Jun 2, 2019
@nblumhardt
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsimbalar tsimbalar tsimbalar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add config overloads to pass both a IConfigSection and IConfiguration
3 participants
@skomis-mm @nblumhardt @tsimbalar