3.1.0 Release #171
Merged
3.1.0 Release #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To pass around the `IConfiguration` object instead of a `static` member
and simplify some method signatures
to avoid checks for null dependencyContext in ConfigurationReader and split responsabilities
and reduce number of arguments to pass around
and protect against null
`licenseUrl` is now deprecated so we use a `license expression`
No longer rely on static state in ConfigurationReader
- ArgumentNullException fix when BaseDirectory is null - additional paths probing: AppDomainSetup.PrivateBinPath, current assembly location path when BaseDirectory is null
- fine-tune ReloadDelay for the DynamicLevelChangeTests
- extract strings to constants
- fixed failing test
…figuration into dev # Conflicts: # src/Serilog.Settings.Configuration/Settings/Configuration/ConfigurationReader.cs
Support simple type names for Serilog types (fixes #81)
Respect dynamic logging level changes for LevelSwitch section
Update Nuget package license format to new format
|
Quite happy to merge "as is". Within the remaining PRs, here is my take on it :
We may want to already increase the version number to |
Added some missing null checks for `settingConfiguration` arguments.
Added missing null checks for settingConfiguration
|
Should we merge what we have and make a I think we should :
Once this is pushed out the door, we can quietly review what to do with :
What do you think ? |
Added new ReadFrom.Configuration(...) overloads; Marked old as obsolete (#148)
…ttest added test to show how to filter child contexts
|
Sounds like a plan, @tsimbalar ! I've merged the three you suggested, and once the build completes I'll make the release 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of new work, plus some approved PRs waiting to go. Shall we assemble a new release of this package? Happy to do the merges/testing etc., if everyone thinks this is ready?