Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 Release #112

Merged
merged 79 commits into from
Oct 7, 2018
Merged

3.0 Release #112

merged 79 commits into from
Oct 7, 2018

Conversation

merbla
Copy link
Contributor

@merbla merbla commented May 15, 2018

nblumhardt and others added 30 commits March 15, 2018 09:26
Use `Console` instead of `LiterateConsole` in README
MS Config and DependencyModel refs updated
@merbla
Copy link
Contributor Author

merbla commented Oct 4, 2018

@tsimbalar @skomis-mm @nblumhardt this one has been open since May, thoughts on when we should release?

@nblumhardt
Copy link
Member

I think once @MV10 's #63 is in, we should hit the button. Would definitely benefit from a close look over for anything we've collectively missed, though.

@tsimbalar
Copy link
Member

Yep, let's ship it when possible, there will be plenty of time for minor releases later on :)

fixes #63 - option to control assembly source
@nblumhardt
Copy link
Member

Last PR is in. Just need to compile list of changes, and eyeball it all for one final sanity-check :-)

@nblumhardt
Copy link
Member

Ah and also this item from @skomis-mm - #112 (comment) - anyone keen to dig in and see how much of that dependency list can be whittled away?

@MV10
Copy link
Contributor

MV10 commented Oct 6, 2018

@skomis-mm was correct, merging a PR to remove that refrerence. SHIP IT!

MV10 and others added 11 commits October 6, 2018 06:32
removed unnecessary package ref
introduced while trying to fix the broken v2.6 release
Support for `WriteTo.Sink(ILogEventSink logEventSink, LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum, LoggingLevelSwitch levelSwitch = null)`
Support for `AuditTo.Sink(ILogEventSink logEventSink, LogEventLevel restrictedToMinimumLevel = LevelAlias.Minimum, LoggingLevelSwitch levelSwitch = null)`
Support for `Enrich.With(ILogEventEnricher enricher)`
Turns out  support for `Filter.With(ILogEventFilter filter)` was already there since commit 4424523
so that all methods in the class are dynamically discovered and exposed to Serilog settings as if they were regular extension methods
@tsimbalar
Copy link
Member

Finally found the time to do #139 and #140 . Fill free to include them in v3.0 as well, but they can also wait for the next minor releaser ;)

…uesyntax

Remove unused class `ConfigurationValueSyntax`
Add support and tests for more configuration methods
@nblumhardt
Copy link
Member

LGTM :-)

@nblumhardt nblumhardt changed the title [WIP] 3.0 Release 3.0 Release Oct 7, 2018
@nblumhardt
Copy link
Member

Going to hit the button on this, and keep a close eye on the repo over the next few days. 👏 to everyone who contributed to this - it's a pretty substantial update!

Great that the wheels are turning again; now that it's close to feature-complete, I think there's still a lot of opportunities to improve ergonomics of the JSON syntax - #49 is desperate for some attention ;-)

@nblumhardt nblumhardt merged commit 51a4fca into master Oct 7, 2018
@MV10
Copy link
Contributor

MV10 commented Oct 7, 2018

I've been thinking about messing around with a #49 implementation (specifically my preference for the "brackety" no-hidden-syntax approach). I have a couple more things I want to wrap up in the SQL sink but I think later this week I can take a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants