Fix #91 - wrong parameter name on surrogate WriteTo.Logger configuration method #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) configuration method
nblumhardt
commented
Mar 15, 2018
| @@ -380,8 +380,12 @@ internal static LoggerConfiguration FromLogContext(LoggerEnrichmentConfiguration | |||
| => loggerEnrichmentConfiguration.FromLogContext(); | |||
|
|
|||
| // Unlike the other configuration methods, Logger is an instance method rather than an extension. | |||
| internal static LoggerConfiguration Logger(LoggerSinkConfiguration loggerSinkConfiguration, Action<LoggerConfiguration> configureLogger, LoggingLevelSwitch restrictedToMinimumLevel = null) | |||
| => loggerSinkConfiguration.Logger(configureLogger, levelSwitch: restrictedToMinimumLevel); | |||
There was a problem hiding this comment.
levelSwitch: restrictedToMinimumLevel is the cause of the chaos.
There was a problem hiding this comment.
oh man :-/ sorry about this one . I'll try to take a look at this one tomorrow to exactly what I missed there... It's way too late here to do any proper thinking :)
There was a problem hiding this comment.
Easy to miss! (I did when reviewing it, anyway! :-))
|
Tested using the sample app locally; unless anyone's around for a quick sanity check, I'll push this through once CI passes. |
|
Build is good; ignoring the build that only increments the package version. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tactical fix for master, will need to come back onto dev.