Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options to control which functions will be build with webpack and whi… #535

Closed
wants to merge 1 commit into from

Conversation

quassnoi
Copy link

@quassnoi quassnoi commented Sep 2, 2019

…ch will not

closes #255

What did you implement:

Closes #255

How did you implement it:

I've added the configuration options to include and exclude functions that will be built using Webpack; made the --function option support multiple entries.

How can we verify it:

  • Create a serverless-webpack configuration with three functions
  • Add one of those functions under custom / webpack / excludeFunctions, make sure Webpack does not try to build that function
  • Add one of those functions under custom / webpack / includeFunctions, make sure Webpack does not try to build functions other than that
  • Run serverless webpack --function func1 --function func2, make sure only Webpack only tries to build func1 and func2

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@quassnoi
Copy link
Author

@HyperBrain @thenikso hey guys, mind reviewing this?

We're using this feature in our scenario, would have been nice to have the real package instead of a fork in our package.json

Thanks!

@quassnoi
Copy link
Author

quassnoi commented Dec 3, 2019

@ceilfors @franciscocpg @HyperBrain @MartinRisk @nathanchapman @rdsedmundo hey guys, are you still supporting this project?

Copy link

@BerkhanBerkdemir BerkhanBerkdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but somebody from the organization should leave a review...

Copy link

@nathanchapman nathanchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

nathanchapman
nathanchapman approved these changes Mar 23, 2020
@smil2k smil2k mentioned this pull request Apr 18, 2020
7 tasks
@j0k3r
Copy link
Member

j0k3r commented Feb 1, 2021

@quassnoi Could you rebase against the master and fix conflicts? Thanks 🙏

@j0k3r j0k3r added the awaiting reply Awaiting for a reply from the OP label Apr 10, 2021
@quassnoi quassnoi closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reply Awaiting for a reply from the OP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip webpack on a per function basis
4 participants