-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for node runtimes first #579
Merged
miguel-a-calles-mba
merged 5 commits into
serverless-heaven:release/5.3.3
from
smil2k:patch-1
Jun 13, 2020
Merged
Check for node runtimes first #579
miguel-a-calles-mba
merged 5 commits into
serverless-heaven:release/5.3.3
from
smil2k:patch-1
Jun 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webpack should not try to load handlers of different runtime than node.
miguel-a-calles-mba
requested changes
May 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests.
@miguel-a-calles-mba I think tests from #530 should be ported here (and then closed) and that PR be merged instead oh the other one (because it handles the global runtime) |
From: Add support for multiple runtimes in service serverless-heaven#530
Works for me @j0k3r. I updated the test. |
7 tasks
miguel-a-calles-mba
approved these changes
Jun 13, 2020
This was referenced Apr 8, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack should not try to load handlers of different runtime than node.
What did you implement:
Closes #255 or #256, #535
How did you implement it:
How can we verify it:
This config will work:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO