Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for node runtimes first #579

Merged
merged 5 commits into from
Jun 13, 2020

Conversation

smil2k
Copy link
Contributor

@smil2k smil2k commented Apr 18, 2020

webpack should not try to load handlers of different runtime than node.

What did you implement:

Closes #255 or #256, #535

How did you implement it:

How can we verify it:

This config will work:

provider:
  name: aws
  runtime: nodejs12.x 

functions:
  echo:
    handler: lambda.echo
    events:
      - http:
          path: /api/echo2
          method: any
  all:
    handler: backend.lambda.LambdaFunction
    runtime: java8
    events:
      - http:
          path: /api/v1/{api+}
          method: any     

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

smil2k and others added 3 commits April 18, 2020 22:19
Copy link
Member

@miguel-a-calles-mba miguel-a-calles-mba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests.

@miguel-a-calles-mba miguel-a-calles-mba added this to the 5.3.3 milestone May 13, 2020
@miguel-a-calles-mba miguel-a-calles-mba requested review from a team May 13, 2020 14:38
@miguel-a-calles-mba miguel-a-calles-mba changed the base branch from master to release/5.3.3 May 13, 2020 14:38
@j0k3r
Copy link
Member

j0k3r commented Jun 12, 2020

@miguel-a-calles-mba I think tests from #530 should be ported here (and then closed) and that PR be merged instead oh the other one (because it handles the global runtime)

@miguel-a-calles-mba
Copy link
Member

Works for me @j0k3r. I updated the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip webpack on a per function basis
3 participants