Skip to content
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.

defines optional servicePort #170

Merged
merged 1 commit into from
Jan 29, 2019
Merged

defines optional servicePort #170

merged 1 commit into from
Jan 29, 2019

Conversation

gimlet2
Copy link
Contributor

@gimlet2 gimlet2 commented Jan 28, 2019

It is followon pull request for vmware-archive/kubeless#993

After updating runtime images to use non-root user it is become impossible to run functions on port 80. To fix this Service can map port 80 to target port 8080. To support this this pull request was prepared. It allows define servicePort to distinguish between container and service ports

Copy link
Contributor

@andresmgot andresmgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andresmgot andresmgot merged commit 151074f into serverless:master Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants