This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
differentiate service port and target port for container #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
reviewed
Jan 29, 2019
There was a problem hiding this comment.
Thanks for the patch @gimlet2! I have just a couple of minor comments.
Co-Authored-By: gimlet2 <andrey.chernishov@gmail.com>
andresmgot
approved these changes
Jan 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Ref: None
Description: After updating runtime images to use non-root user it is become impossible to run functions on port 80. To fix this
Servicecan map port 80 to target port 8080. To support this this pull request was prepared. Also another one will come toserverless-kubelessplugin.TODOs: