fix: Skip functions that do not use node runtime. Allows mixed runtime projects #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 3, 2020 14:38
This fixes issues with the mixed types of exports so other code (tests) can import TypeScriptPlugin.
vectorjohn
changed the title
This was referenced Feb 3, 2020
|
Can we please merge this. Without this addition, it forces an entire code base to use the same runtime. |
|
I have the same issue! Please merge this PR! 🙏 |
|
It looks like a version of this was merged by #277 so I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a project that needs to use some Java functions but the majority is using typescript. Unless I'm missing something, I didn't see a way to do that with this plugin because it attempts to tsc every function and of course fails. It entirely ignores the runtime choice. So I added getNodeFunctions which just returns this.functions and filters based on the runtime (function specific or service.provider.runtime). This is used instead of this.functions in
rootFileNames()as well asmoveArtifacts.Moved TypeScriptPlugin class into its own file to not have conflicting export mechanisms. Needed by the new test. There might be a better fix, but the code as written complained in tests that TypeScriptPlugin was not a constructor when I tried importing from index.js, I think it's because the class was exported and also module.exports was replaced.