-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix runtime not being python #745
Conversation
Thanks @mklenbw - sorry for not responding sooner, but I've been very busy lately, I'll try to review this PR by the end of the week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mklenbw, thanks a lot for your patience, I'm really sorry that I wasn't able to respond sooner to your PR. Do you think you could introduce a test case that covers this case? Please let me know what do you think 🙇
Sure. I'll add it right away and text you. |
+1 Also facing this issue. Appreciate the PR! |
@pgrzesik |
Hey @mklenbw, thank you so much 🙇 Unforutnatelly it looks like formatting is failing, could you please check that? |
@pgrzesik Got it fixed. Forgot to run prettier. You should consider including husky. |
Hey @mklenbw - thank you, there's a leftover |
@pgrzesik |
@pgrzesik If someone wants to continue this topic please take my code and get it to work. I would love to see this masterpiece of a plugin in it's full glance again. |
No worries, sorry that it became an issue and thanks for all the effors @mklenbw 👍 I'll try to wrap this up over the weekend. I'm trying to keep the lights on with this particular plugin but unfortunately my time has been very limited lately. |
+1 for would love to see this fixed |
thanks @jameskbride - I'll close this one and respond in other PR |
When runtime is not set to python don't use it as pythonBin.
Closes: #741