Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime not being python (cont.) #773

Merged
merged 11 commits into from
Aug 17, 2023

Conversation

jameskbride
Copy link
Contributor

Context

This is a continuation of the work done in #745, which should address #741 by enabling non-Python runtimes to be specified in provider.runtime attribute of the serverless config.

Changes

  • Fix runtime not being python
  • Added test
  • Ignoring test-generated packages.
  • Adding .python-version file for the required version of Python.
  • Updating the CONTRIBUTING.md instructions.

Testing

  • Unit tested

Copy link
Collaborator

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks nice, I have one comment, please let me know what do you think

CONTRIBUTING.md Show resolved Hide resolved
Copy link
Collaborator

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sir 🙇

@pgrzesik pgrzesik merged commit c1f5ca1 into serverless:master Aug 17, 2023
@jameskbride
Copy link
Contributor Author

No problem, glad to help! 😃

@jameskbride
Copy link
Contributor Author

@pgrzesik Any chance of getting a release out with this fix in the near future? Thanks!

@pgrzesik
Copy link
Collaborator

Hey @jameskbride - yes, I intend to prepare a new release later this week, sorry about the delay

@jameskbride
Copy link
Contributor Author

No worries, thanks!

@william-valencia
Copy link

Any update on the release?

mLupine added a commit to mLupine/serverless-python-requirements that referenced this pull request Nov 3, 2023
* master:
  Release v6.0.1 (serverless#793)
  ci: Temporarily disable test run on integrate (serverless#800)
  ci: Temporarily minimize testing matrix (serverless#799)
  ci: Fix test skips (serverless#797)
  ci: Temp skip of cache-related tests (serverless#796)
  ci: Remove node12 from testing matrix (serverless#795)
  fix: Not crash when runtime is not `python` (serverless#773)
  fix: Remove outdated Pipenv requirements flag (serverless#780)
  fix: Fix integration test matrix configuration (serverless#755)
  fix: Add legacy `pipenv` backward compatability (serverless#742)
  Add support for specifying custom dependency groups in Poetry (serverless#746)
  docs: Add contributing and code of conduct

# Conflicts:
#	test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants