Workflow validations #156
Merged
Workflow validations #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spolti
reviewed
Mar 8, 2023
spolti
reviewed
Mar 8, 2023
spolti
reviewed
Mar 8, 2023
|
@ribeiromiranda I need you to sign the DCO and your commits. Many thanks for this! I'll review it later. |
ribeiromiranda
force-pushed
the
validators
branch
2 times, most recently
from
b22bdad
to
7b4c2e2
Compare
ribeiromiranda
force-pushed
the
validators
branch
from
57245f2
to
994a77d
Compare
workflow parameters validations: * id and key: add required_without * start: required, create a custom validator to check if state exists on the workflow states Others: * Workflow.Start: if the start is not defined, use the first workflow state * State.UnmarshalJSON: removed return from switch not need * State.UnmarshalJSON: when state type is nil return a error message Signed-off-by: André R. de Miranda <andre@galgo.tech>
Signed-off-by: André R. de Miranda <andre@galgo.tech>
Signed-off-by: André R. de Miranda <andre@galgo.tech>
…rom parser/parser_test.go Signed-off-by: André R. de Miranda <andre@galgo.tech>
|
@ribeiromiranda can u take a look at the CI errors? |
spolti
reviewed
Mar 9, 2023
ribeiromiranda
force-pushed
the
validators
branch
from
f5fad5d
to
26f0b21
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
… and "end" validator: add to BaseState; fix failed unit tests; refactor SwitchState validator. Signed-off-by: André R. de Miranda <andre@galgo.tech>
ribeiromiranda
force-pushed
the
validators
branch
from
247d479
to
03e4dc8
Compare
Signed-off-by: André R. de Miranda <andre@galgo.tech>
…equired in the `Transition` struct field. Signed-off-by: André R. de Miranda <andre@galgo.tech>
spolti
reviewed
Mar 10, 2023
Signed-off-by: André R. de Miranda <andre@galgo.tech>
ricardozanini
approved these changes
Mar 13, 2023
Yes |
spolti
approved these changes
Mar 13, 2023
|
Many thanks @ribeiromiranda. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow parameters validations
Issue: #153