Drop "Custom Projection" #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebhale
approved these changes
Mar 1, 2021
arthurdm
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
+1 the configuration / mapping is a much lower bar for non-Pod'specable resources.
Granted that the Custom Projection does allow for a wider set of resources to participate in Service Binding, as there can be resources in the field that are not Pod'specable and also cannot be directly mapped to containers / env / etc - but that does not seem to be a common scenario, and requires their controller to update their code.
|
This simplifies things a lot 👍 |
Merged
Use "Application Resource Mapping" instead. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
scothis
force-pushed
the
drop-custom-projection
branch
from
51fda96 to
cce5453
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "Application Resource Mapping" instead.
Using this PR to start the discussion as to whether we can drop the "Custom Projection" support. Dissatisfaction with "Custom Projection" is what led us to add "Application Resource Mapping" to the spec.