Improve specificity of tempfile dependency
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jun 7, 2019
Add Windows arm64 build. Depends on: * [ ] servo/mozjs#184 * [ ] servo/ipc-channel#232 * [ ] rust-lang/cmake-rs#82 * [ ] servo/surfman#136 * [ ] servo/mozangle#21 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jun 7, 2019
Add Windows arm64 build. Depends on: * [ ] servo/mozjs#184 * [ ] servo/ipc-channel#232 * [ ] rust-lang/cmake-rs#82 * [ ] servo/surfman#136 * [ ] servo/mozangle#21 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468) <!-- Reviewable:end -->
bors-servo
referenced
this pull request
in servo/servo
Jun 7, 2019
Add Windows arm64 build. Depends on: * [ ] servo/mozjs#184 * [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike> * [x] rust-lang/cmake-rs#82 * [ ] servo/surfman#136 * [ ] servo/mozangle#21 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468) <!-- Reviewable:end -->
bors-servo
referenced
this pull request
in servo/servo
Jun 7, 2019
Add Windows arm64 build. Depends on: * [x] servo/mozjs#184 * [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike> * [x] rust-lang/cmake-rs#82 * [ ] servo/surfman#136 * [ ] servo/mozangle#21 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468) <!-- Reviewable:end -->
bors-servo
referenced
this pull request
in servo/servo
Jun 11, 2019
Add Windows arm64 build. Depends on: * [x] servo/mozjs#184 * [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike> * [x] rust-lang/cmake-rs#82 * [x] servo/surfman#136 * [x] servo/mozangle#21 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468) <!-- Reviewable:end -->
bors-servo
referenced
this pull request
in servo/servo
Jun 11, 2019
Add Windows arm64 build. Depends on: * [x] servo/mozjs#184 * [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike> * [x] rust-lang/cmake-rs#82 * [x] servo/surfman#136 * [x] servo/mozangle#21 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468) <!-- Reviewable:end -->
bors-servo
referenced
this pull request
in servo/servo
Jun 11, 2019
Add Windows arm64 build. Depends on: * [x] servo/mozjs#184 * [x] servo/rust-mozjs#463 * [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike> * [x] rust-lang/cmake-rs#82 * [x] servo/surfman#136 * [x] servo/mozangle#21 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468) <!-- Reviewable:end -->
bors-servo
referenced
this pull request
in servo/servo
Jun 11, 2019
Add Windows arm64 build. Depends on: * [x] servo/mozjs#184 * [x] servo/rust-mozjs#463 * [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike> * [x] rust-lang/cmake-rs#82 * [x] servo/surfman#136 * [x] servo/mozangle#21 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468) <!-- Reviewable:end -->
|
☔ The latest upstream changes (presumably #237) made this pull request unmergeable. Please resolve the merge conflicts. |
mrobinson
changed the title
tempfile dependency
mrobinson
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids having to compile tempfile for Windows arm64, where it has an unsupported dependency.