Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve libEGL build for Windows arm64 #21

Merged
merged 3 commits into from
Jun 10, 2019
Merged

Improve libEGL build for Windows arm64 #21

merged 3 commits into from
Jun 10, 2019

Conversation

jdm
Copy link
Member

@jdm jdm commented Jun 7, 2019

This disables the use of SSE2 in libEGL on non-Intel targets, and also generates a static libEGL.lib.

bors-servo pushed a commit to servo/servo that referenced this pull request Jun 7, 2019
Add Windows arm64 build.

Depends on:
* [ ] servo/mozjs#184
* [ ] servo/ipc-channel#232
* [ ] rust-lang/cmake-rs#82
* [ ] servo/surfman#136
* [ ] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Jun 7, 2019
Add Windows arm64 build.

Depends on:
* [ ] servo/mozjs#184
* [ ] servo/ipc-channel#232
* [ ] rust-lang/cmake-rs#82
* [ ] servo/surfman#136
* [ ] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
@jdm
Copy link
Member Author

jdm commented Jun 7, 2019

@bors-servo try=windows

@bors-servo
Copy link
Contributor

🙁 This repo does not have try choosers set up

bors-servo pushed a commit that referenced this pull request Jun 7, 2019
Improve libEGL build for Windows arm64

This disables the use of SSE2 in libEGL on non-Intel targets, and also generates a static libEGL.lib.
@bors-servo
Copy link
Contributor

⌛ Trying commit 3e5d999 with merge 40ea9cd...

bors-servo pushed a commit to servo/servo that referenced this pull request Jun 7, 2019
Add Windows arm64 build.

Depends on:
* [ ] servo/mozjs#184
* [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike>
* [x] rust-lang/cmake-rs#82
* [ ] servo/surfman#136
* [ ] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - status-appveyor

bors-servo pushed a commit to servo/servo that referenced this pull request Jun 7, 2019
Add Windows arm64 build.

Depends on:
* [x] servo/mozjs#184
* [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike>
* [x] rust-lang/cmake-rs#82
* [ ] servo/surfman#136
* [ ] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
@jdm
Copy link
Member Author

jdm commented Jun 10, 2019

Randomly rolling the reviewer die, r? @Manishearth

@Manishearth
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 29616d9 has been approved by Manishearth

bors-servo pushed a commit that referenced this pull request Jun 10, 2019
Improve libEGL build for Windows arm64

This disables the use of SSE2 in libEGL on non-Intel targets, and also generates a static libEGL.lib.
@bors-servo
Copy link
Contributor

⌛ Testing commit 29616d9 with merge 2198a13...

@bors-servo
Copy link
Contributor

💔 Test failed - checks-travis

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing 2198a13 to master...

@bors-servo bors-servo merged commit 29616d9 into servo:master Jun 10, 2019
bors-servo pushed a commit to servo/servo that referenced this pull request Jun 11, 2019
Add Windows arm64 build.

Depends on:
* [x] servo/mozjs#184
* [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike>
* [x] rust-lang/cmake-rs#82
* [x] servo/surfman#136
* [x] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Jun 11, 2019
Add Windows arm64 build.

Depends on:
* [x] servo/mozjs#184
* [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike>
* [x] rust-lang/cmake-rs#82
* [x] servo/surfman#136
* [x] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Jun 11, 2019
Add Windows arm64 build.

Depends on:
* [x] servo/mozjs#184
* [x] servo/rust-mozjs#463
* [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike>
* [x] rust-lang/cmake-rs#82
* [x] servo/surfman#136
* [x] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/servo that referenced this pull request Jun 11, 2019
Add Windows arm64 build.

Depends on:
* [x] servo/mozjs#184
* [x] servo/rust-mozjs#463
* [ ] <strike>https://github.com/servo/ipc-channel/pull/232</strike>
* [x] rust-lang/cmake-rs#82
* [x] servo/surfman#136
* [x] servo/mozangle#21

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23468)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants