Linux: Fix corruption of big transfers on 32 bit systems #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong size calculation magically worked on 64 bit systems, because 2 * sizeof u32 is the same as sizeof usize there -- but not on 32 bit systems, where this dropped 4 bytes of each full fragment.
|
r? @pcwalton |
|
Oh my goodness. Thank you for digging into this! |
|
@bors-servo: r+ |
|
📌 Commit 8808491 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 12, 2016
Linux: Fix corruption of big transfers on 32 bit systems The wrong size calculation magically worked on 64 bit systems, because 2 * sizeof u32 is the same as sizeof usize there -- but not on 32 bit systems, where this dropped 4 bytes of each full fragment. With this, Servo works again for me. (And we are down to 4 failing ipc-channel tests on my system...)
|
💔 Test failed - travis |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Jan 13, 2016
Linux: Fix corruption of big transfers on 32 bit systems The wrong size calculation magically worked on 64 bit systems, because 2 * sizeof u32 is the same as sizeof usize there -- but not on 32 bit systems, where this dropped 4 bytes of each full fragment. With this, Servo works again for me. (And we are down to 4 failing ipc-channel tests on my system...)
|
☀️ Test successful - travis |
antrik
added a commit
to antrik/servo
that referenced
this pull request
Jan 13, 2016
This pulls in servo/ipc-channel#25 and servo/ipc-channel#12 servo#27, thus fixing fallout from the multiprocess split, and making Servo work on my system again. (It also pulls in servo/ipc-channel#12 -- I guess that's fine?)
antrik
added a commit
to antrik/servo
that referenced
this pull request
Jan 13, 2016
This pulls in servo/ipc-channel#25 and servo/ipc-channel#27, thus fixing fallout from the multiprocess split, and making Servo work on my system again. (It also pulls in servo/ipc-channel#12 -- I guess that's fine?)
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jan 14, 2016
cargo-update ipc-channel to get important fixes This pulls in servo/ipc-channel#25 and servo/ipc-channel#27, thus fixing fallout from the multiprocess split, and making Servo work on my system again. (It also pulls in servo/ipc-channel#12 -- I guess that's fine?) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9299) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jan 14, 2016
cargo-update ipc-channel to get important fixes This pulls in servo/ipc-channel#25 and servo/ipc-channel#27, thus fixing fallout from the multiprocess split, and making Servo work on my system again. (It also pulls in servo/ipc-channel#12 -- I guess that's fine?) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9299) <!-- Reviewable:end -->
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…(from antrik:update-ipc_channel); r=pcwalton This pulls in servo/ipc-channel#25 and servo/ipc-channel#27, thus fixing fallout from the multiprocess split, and making Servo work on my system again. (It also pulls in servo/ipc-channel#12 -- I guess that's fine?) Source-Repo: https://github.com/servo/servo Source-Revision: 42372dbdf112c1c2967c4487401b28e7305c2993 UltraBlame original commit: d16cecf007bc7760538afc4ec593b1d6580648f2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…(from antrik:update-ipc_channel); r=pcwalton This pulls in servo/ipc-channel#25 and servo/ipc-channel#27, thus fixing fallout from the multiprocess split, and making Servo work on my system again. (It also pulls in servo/ipc-channel#12 -- I guess that's fine?) Source-Repo: https://github.com/servo/servo Source-Revision: 42372dbdf112c1c2967c4487401b28e7305c2993 UltraBlame original commit: d16cecf007bc7760538afc4ec593b1d6580648f2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…(from antrik:update-ipc_channel); r=pcwalton This pulls in servo/ipc-channel#25 and servo/ipc-channel#27, thus fixing fallout from the multiprocess split, and making Servo work on my system again. (It also pulls in servo/ipc-channel#12 -- I guess that's fine?) Source-Repo: https://github.com/servo/servo Source-Revision: 42372dbdf112c1c2967c4487401b28e7305c2993 UltraBlame original commit: d16cecf007bc7760538afc4ec593b1d6580648f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong size calculation magically worked on 64 bit systems, because
2 * sizeof u32 is the same as sizeof usize there -- but not on 32 bit
systems, where this dropped 4 bytes of each full fragment.
With this, Servo works again for me. (And we are down to 4 failing ipc-channel tests on my system...)