Linux: Don't pass uninitialised memory as pointers to libc::connect() #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know whether there are constellations where taking a reference to a binding containing mem::uninitialized() actually creates a proper NULL pointer -- but it certainly doesn't on my system when using the rustc snapshot from Servo. Either way, creating explicit NULL pointers seems way more correct. This fixes the other four testsuite failures, as well as servo -M
|
What testsuite failures are you referring to? |
|
All the tests using IpcOneShotServer are failing on my system without this fix -- including platform::test::server, platform::test::cross_process, platform::test::cross_process_sender_transfer, and test::cross_process_embedded_senders. (And servo -m accordingly also panics on IpcOneShotServer.) |
|
Would be nice if we could test this in automation. This looks correct from the manpage, though. @bors-servo r+ |
|
📌 Commit 30abbf5 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jan 8, 2016
Linux: Don't pass uninitialised memory as pointers to libc::connect() I don't know whether there are constellations where taking a reference to a binding containing mem::uninitialized() actually creates a proper NULL pointer -- but it certainly doesn't on my system when using the rustc snapshot from Servo. Either way, creating explicit NULL pointers seems way more correct. This fixes the other four testsuite failures, as well as servo -M
|
💔 Test failed - travis |
|
And that's rust-lang/rust#30713 |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Jan 12, 2016
Linux: Don't pass uninitialised memory as pointers to libc::connect() I don't know whether there are constellations where taking a reference to a binding containing mem::uninitialized() actually creates a proper NULL pointer -- but it certainly doesn't on my system when using the rustc snapshot from Servo. Either way, creating explicit NULL pointers seems way more correct. This fixes the other four testsuite failures, as well as servo -M
|
💔 Test failed - travis |
|
Heh, now aster/quasi_codegen is broken, great |
|
@bors-servo: retry (serde-deprecated/quasi#29) |
bors-servo
pushed a commit
that referenced
this pull request
Jan 12, 2016
Linux: Don't pass uninitialised memory as pointers to libc::connect() I don't know whether there are constellations where taking a reference to a binding containing mem::uninitialized() actually creates a proper NULL pointer -- but it certainly doesn't on my system when using the rustc snapshot from Servo. Either way, creating explicit NULL pointers seems way more correct. This fixes the other four testsuite failures, as well as servo -M
|
💔 Test failed - travis |
|
Dang it, not published yet |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Jan 13, 2016
Linux: Don't pass uninitialised memory as pointers to libc::connect() I don't know whether there are constellations where taking a reference to a binding containing mem::uninitialized() actually creates a proper NULL pointer -- but it certainly doesn't on my system when using the rustc snapshot from Servo. Either way, creating explicit NULL pointers seems way more correct. This fixes the other four testsuite failures, as well as servo -M
|
☀️ Test successful - travis |
|
\o/ |
antrik
added a commit
to antrik/servo
that referenced
this pull request
Jan 13, 2016
This pulls in servo/ipc-channel#25 and servo/ipc-channel#27, thus fixing fallout from the multiprocess split, and making Servo work on my system again. (It also pulls in servo/ipc-channel#12 -- I guess that's fine?)
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jan 14, 2016
cargo-update ipc-channel to get important fixes This pulls in servo/ipc-channel#25 and servo/ipc-channel#27, thus fixing fallout from the multiprocess split, and making Servo work on my system again. (It also pulls in servo/ipc-channel#12 -- I guess that's fine?) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9299) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Jan 14, 2016
cargo-update ipc-channel to get important fixes This pulls in servo/ipc-channel#25 and servo/ipc-channel#27, thus fixing fallout from the multiprocess split, and making Servo work on my system again. (It also pulls in servo/ipc-channel#12 -- I guess that's fine?) <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9299) <!-- Reviewable:end -->
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 1, 2019
…(from antrik:update-ipc_channel); r=pcwalton This pulls in servo/ipc-channel#25 and servo/ipc-channel#27, thus fixing fallout from the multiprocess split, and making Servo work on my system again. (It also pulls in servo/ipc-channel#12 -- I guess that's fine?) Source-Repo: https://github.com/servo/servo Source-Revision: 42372dbdf112c1c2967c4487401b28e7305c2993 UltraBlame original commit: d16cecf007bc7760538afc4ec593b1d6580648f2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…(from antrik:update-ipc_channel); r=pcwalton This pulls in servo/ipc-channel#25 and servo/ipc-channel#27, thus fixing fallout from the multiprocess split, and making Servo work on my system again. (It also pulls in servo/ipc-channel#12 -- I guess that's fine?) Source-Repo: https://github.com/servo/servo Source-Revision: 42372dbdf112c1c2967c4487401b28e7305c2993 UltraBlame original commit: d16cecf007bc7760538afc4ec593b1d6580648f2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…(from antrik:update-ipc_channel); r=pcwalton This pulls in servo/ipc-channel#25 and servo/ipc-channel#27, thus fixing fallout from the multiprocess split, and making Servo work on my system again. (It also pulls in servo/ipc-channel#12 -- I guess that's fine?) Source-Repo: https://github.com/servo/servo Source-Revision: 42372dbdf112c1c2967c4487401b28e7305c2993 UltraBlame original commit: d16cecf007bc7760538afc4ec593b1d6580648f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know whether there are constellations where taking a reference
to a binding containing mem::uninitialized() actually creates a proper
NULL pointer -- but it certainly doesn't on my system when using the
rustc snapshot from Servo.
Either way, creating explicit NULL pointers seems way more correct.
This fixes the other four testsuite failures, as well as servo -M