Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach from winit? #205

Closed
kvark opened this issue Nov 3, 2020 · 5 comments
Closed

Detach from winit? #205

kvark opened this issue Nov 3, 2020 · 5 comments

Comments

@kvark
Copy link
Member

kvark commented Nov 3, 2020

Winit releases new versions quite often, at least more often than surfman. And it's a dependency of surfman. So once we start depending on surfman in Gecko, there is a problem of dependency duplication that could arise from winit (e.g. cocoa stuff). Gecko doesn't like duplicated dependencies because Mercurial is bad at vendoring them.

Would it be possible to somehow avoid depending on winit in sm-winit feature? Perhaps, by moving the stable part of winit into a separate crate, or something like that.

bors-servo added a commit that referenced this issue Nov 3, 2020
Don't depend on winit by default

I don't think it's needed here. Adding a feature is always easier for consumers than removing one.
Related to #205
@kvark
Copy link
Member Author

kvark commented Nov 3, 2020

Actually, it looks like surfman also depends on the macOS crates directly, so it's already in trouble :/
I wonder how Servo team planned to manage the dependency duplication here?

@jdm
Copy link
Member

jdm commented Nov 3, 2020

@wusyong
Copy link
Member

wusyong commented Jun 7, 2023

surfman now has a sm-raw-window-handle that can feed it with raw window types.
I'm thinking about making an abstraction in servo demo too. So other windowing tools like glazier, or other tool kits like Gtk can use servo too.
But Connection::from_raw_display_handle is added after 0.6.
Could surfman publish another version if any maintainer has time?

@jdm
Copy link
Member

jdm commented Jun 16, 2023

Published!

@atouchet
Copy link
Contributor

This was done in #271.

@jdm jdm closed this as completed Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants