-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detach from winit? #205
Comments
Don't depend on winit by default I don't think it's needed here. Adding a feature is always easier for consumers than removing one. Related to #205
Actually, it looks like surfman also depends on the macOS crates directly, so it's already in trouble :/ |
We allow duplication on a crate-by-crate basis in https://github.com/servo/servo/blob/071d1d824833dc6103251591e07d8e1bdcea39c0/servo-tidy.toml#L29-L79. |
surfman now has a |
Published! |
This was done in #271. |
Winit releases new versions quite often, at least more often than surfman. And it's a dependency of surfman. So once we start depending on surfman in Gecko, there is a problem of dependency duplication that could arise from
winit
(e.g. cocoa stuff). Gecko doesn't like duplicated dependencies because Mercurial is bad at vendoring them.Would it be possible to somehow avoid depending on winit in
sm-winit
feature? Perhaps, by moving the stable part of winit into a separate crate, or something like that.The text was updated successfully, but these errors were encountered: