Remove the winit feature #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we can use raw_window_handle, drop the winit feature. This should make the dependency graph a little bit less complicated for crates that depend on surfman. A few changes: - The Wayland implementation needs the size when creating a native widget from a raw window handle, so add that parameters Unfortunately, it doesn't look like there is another option here. - Rename create_native_widget_from_rwh to create_native_widget_from_raw_window_handle. There already exists API that uses the `raw_window_handle` terminology. - Try to fix the build of the android-example, which depended on the old winit and now depends on the new one. This is a breaking API change, so the next release should be a major version bump.
jdm
approved these changes
Jan 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can use raw_window_handle, drop the winit feature. This should make the dependency graph a little bit less complicated for crates that depend on surfman.
A few changes:
create_native_widget_from_rwhtocreate_native_widget_from_raw_window_handle. There already exists API that uses theraw_window_handleterminology.This is a breaking API change, so the next release should be a major version bump.