-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: avocado protection (🥑) #43
Conversation
630f6a3
to
f0fcb1c
Compare
e608746
to
2a3bbf6
Compare
Actually, some of the smashed avocados will be repaired by this technique, so more like 70% repairable? |
Looking at the sample again, it's fixing 11 out of 14 completely. Of the three: 2 are "dirty avocados". One has inclusions confined to the border, so it will be fine. One has inclusions that extend into the cell, which is more problematic. The last is a sliced avocado that failed it seems because the slice extended across two slices and blocked 3/6 votes, failing to achieve a majority. For dirty avocados, maybe we can try painting the wall before filling? |
test: add simple avocado test
There's a bug in fastremap and we'll need to update for this test to work. |
Slow but it seems to mostly work. Dirty avocados won't be fully fixed if the inclusions touch the edges of the box. We're using a fudge factor of 2.5 to try to capture nucleii. With the latest changes, it looks like 13/14 avocados are fully fixed (93%) with one partially fixed in my test set. |
Addresses #40
This will get us to about 70% avocado protection but doesn't seem to fix sliced avocados nor dirty avocados yet. I have some ideas though...