Converted ToSql usage to impl IntoIterator #446
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #265 and #445. This is about as far as I could get with me being new to Rust.
There's still issues:
&[]
) has to be explicity cast to&[some type that implements ToSql (like i32)]
. Example:&[] as &[i32]
. I'd prefer being able to use the existing method of just sending an empty&[]
, as that would cause no breakage with existing usage.test_bpchar_params
fails because I don't know how to work withNone::<&'static str>
.@sfackler, could you take a look at this and see how we might be able to fix these things?