Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load a default SFZ if path empty #283

Merged
merged 2 commits into from
Jun 21, 2020
Merged

Conversation

jpcima
Copy link
Collaborator

@jpcima jpcima commented Jun 20, 2020

This loads the sine by default, or when the sfz file parameter is empty.

@jpcima jpcima requested a review from paulfd June 20, 2020 11:21
@paulfd
Copy link
Member

paulfd commented Jun 20, 2020

What about putting a small envelope on the default? e.g. ampeg_attack=0.02 ampeg_release=0.1 or something reasonable?

@jpcima
Copy link
Collaborator Author

jpcima commented Jun 20, 2020

I'd rather keep it the simplest.
For later, I thought we can collect some example synth-based patches and present them under the new ui.
It's as a way to exhibit some of sfizz sfz features.

@paulfd
Copy link
Member

paulfd commented Jun 20, 2020 via email

@jpcima
Copy link
Collaborator Author

jpcima commented Jun 20, 2020

Resolved. In preparation of a release, I've prepared this PR on the suggestion of @alcomposer.
Also I did this well needed vst update regarding tuning.
The smoothers are looking ok except that I didn't give this a lot of tests.
Do you wish to add the polyphony improvements? regarding #275 and what may come next

@paulfd
Copy link
Member

paulfd commented Jun 21, 2020

I think I can at least port the current voice stealing to the new structure of #275 but I'm gonna have a busy couple of weeks I realize. One goal of #275 is to have common voice stealing algorithms regardless of why you need to voice steal (i.e. which polyphony limit you hit), and this should be a small PR on top of #275 . Further goals included finer stealing algorithms and the ability to select the algorithm at runtime, overflow voices and the like but this can probably wait for a further release 🙂

@jpcima jpcima merged commit 3b5f215 into sfztools:develop Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants