Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Region sets #275

Merged
merged 11 commits into from
Jul 2, 2020
Merged

Region sets #275

merged 11 commits into from
Jul 2, 2020

Conversation

paulfd
Copy link
Member

@paulfd paulfd commented Jun 15, 2020

  • Add the region sets (hierarchy)
  • Link the voice lifecycle into region sets and polyphony groups
  • Respect crudely the polyphony limits without stealing for now

@paulfd paulfd requested a review from jpcima June 15, 2020 10:04
@paulfd paulfd force-pushed the group-hierarchy branch from 1ab8361 to cd0b715 Compare June 15, 2020 12:19
jpcima
jpcima reviewed Jun 15, 2020
View reviewed changes
src/sfizz/Synth.h Outdated Show resolved Hide resolved
jpcima
jpcima reviewed Jun 15, 2020
View reviewed changes
src/sfizz/RegionSet.h Outdated Show resolved Hide resolved
@jpcima jpcima mentioned this pull request Jun 20, 2020
Merged
@paulfd
Copy link
Member Author

paulfd commented Jun 21, 2020

Maybe let me put the voice stealing logic within this PR to make it more self contained and I'll undraft it when done!

@paulfd paulfd marked this pull request as draft June 21, 2020 09:03
@paulfd paulfd mentioned this pull request Jun 22, 2020
Closed
@paulfd paulfd linked an issue Jun 22, 2020 that may be closed by this pull request
Group-level opcodes considered "unknown" #231
Closed
@paulfd paulfd mentioned this pull request Jun 22, 2020
Closed
@paulfd paulfd linked an issue Jun 22, 2020 that may be closed by this pull request
Polyphony opcode within <region> #259
Closed
@paulfd paulfd force-pushed the group-hierarchy branch from 925eeaa to ce34b6b Compare June 22, 2020 21:51
@paulfd paulfd marked this pull request as ready for review June 22, 2020 21:55
@paulfd paulfd requested a review from jpcima June 22, 2020 21:56
@paulfd paulfd marked this pull request as draft June 22, 2020 21:57
jpcima
jpcima reviewed Jun 22, 2020
View reviewed changes
src/sfizz/VoiceStealing.h Outdated Show resolved Hide resolved
@paulfd paulfd marked this pull request as ready for review June 22, 2020 22:24
@paulfd
Copy link
Member Author

paulfd commented Jun 22, 2020

I was a bit too fast on the previous review request as some tests were not passing. Sorry.

@paulfd paulfd requested a review from jpcima June 28, 2020 21:14
@paulfd paulfd linked an issue Jul 1, 2020 that may be closed by this pull request
Drumset voices not playing after the Nth one #243
Closed
@paulfd paulfd force-pushed the group-hierarchy branch from 878cdcb to f047074 Compare July 2, 2020 08:09
@paulfd paulfd force-pushed the group-hierarchy branch from f047074 to b8a23ee Compare July 2, 2020 08:15
@paulfd paulfd merged commit 87be038 into sfztools:develop Jul 2, 2020
@paulfd paulfd deleted the group-hierarchy branch July 2, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpcima jpcima jpcima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@paulfd @jpcima