Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package exports for cli and types #24

Merged
merged 1 commit into from
Mar 30, 2024
Merged

fix: package exports for cli and types #24

merged 1 commit into from
Mar 30, 2024

Conversation

sgammon
Copy link
Owner

@sgammon sgammon commented Mar 30, 2024

  • fix: package exports for main entrypoint
  • fix: missing type field in package.json
  • fix: better type mappings for require/import
  • chore: add publint step
  • chore: bump version → 1.0.2

@sgammon sgammon added the bug Something isn't working label Mar 30, 2024
@sgammon sgammon self-assigned this Mar 30, 2024
Comment on lines +41 to +48
"import": {
"types": "./dist/index.d.mts",
"default": "./dist/esm/index.mjs"
},
"require": {
"types": "./dist/index.d.ts",
"default": "./dist/cjs/index.js"
},
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes for issues reported here

Copy link
Collaborator

@darvld darvld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

- fix: package exports for main entrypoint
- fix: missing `type` field in `package.json`
- fix: better type mappings for require/import
- fix: run build before lint step
- chore: add `publint` step
- chore: bump version → `1.0.2`

Signed-off-by: Sam Gammon <sam@elide.ventures>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sgammon sgammon enabled auto-merge (rebase) March 30, 2024 23:37
auto-merge was automatically disabled March 30, 2024 23:38

Base branch requires signed commits

@sgammon sgammon merged commit 0464590 into main Mar 30, 2024
29 checks passed
@sgammon sgammon deleted the fix/exports branch March 30, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants