Fix newline under each section #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgnl05 yes I saw that awhile back. I think maybe the ruby 1.9.3 ordering introduced it. It definitely used to have newlines between sections and I do think it is more readable that way. |
|
@sgnl05 I tested this in our environment with no issue. Login continues to work as expected on RHEL 5,6,7 and Ununtu 14.04 LTS |
|
Great, thanks! |
sgnl05
added a commit
that referenced
this pull request
Aug 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@edestecd I'm trying to fix an issue where every section in sssd.conf gets written without being split by a new line. Do you have this issue? Can you please test how this commit affects your setup?