-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Service[oddjobd] failing to start #22
Conversation
hmm, I have not seen this. Can you help by indicating the OS and version you are using? |
CentOS release 6.7 (Final) I think the issue is the base image I’m working with has the messagebus service disabled and stopped. It needs to come online before oddjobd and I didn’t want to write an entire module just to handle this edge case so I took the approach of specifying it as a dependency by default that can be overridden if messagebus needs to be managed somewhere else in the catalog. Curious what you think and happy to take a different approach to solve the problem if you think it’s best. Cheers, |
786e6c5
to
eb9fe9a
Compare
@jeffmccune You can fix travis failing by incorporating these lines into the Gemfile https://github.com/Ericsson/puppet-module-cron/blob/master/Gemfile#L27-L39 |
eb9fe9a
to
188aa60
Compare
@ghoneycutt Gemfile updated in 64df4f1 |
This patch fixes the following error when running automated tests in Travis with MRI 1.9.3: Gem::InstallError: json_pure requires Ruby version ~> 2.0.
188aa60
to
83f0296
Compare
Without this patch the initial Puppet run fails with the following error message: Error: Could not start Service[oddjobd]: Execution of '/sbin/service oddjobd start' returned 1: Starting oddjobd: [FAILED] The cause of this error is that the `messagebus` service is not started. This patch addresses the problem by adding optional management of dependent services to the sssd::services class. Since these dependencies aren't strictly related to sssd they can easily be overridden by setting sssd::service_dependencies to an empty array in Hiera.
83f0296
to
d7092a9
Compare
+1 @sgnl05 Could you please take a look? I think we are ready for merge. |
Looks good. Thanks! |
Thanks @sgnl05 Could you please tag this as a new release? |
Fixed |
Released in 0.3.1 Thank you everyone! |
Without this patch the initial Puppet run fails with the following error
message:
The cause of this error is that the
messagebus
service is not started. Thispatch addresses the problem by adding optional management of dependent services
to the sssd::services class. Since these dependencies aren't strictly related
to sssd they can easily be overridden by setting sssd::service_dependencies to
an empty array in Hiera.