Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce an ApplicationUtils class to group Shaarli (application) utils #372

Closed
4 of 12 tasks
virtualtam opened this issue Nov 9, 2015 · 1 comment
Closed
4 of 12 tasks

Introduce an ApplicationUtils class to group Shaarli (application) utils #372

virtualtam opened this issue Nov 9, 2015 · 1 comment
Assignees
@virtualtam
Labels
cleanup code cleanup and refactoring enhancement
Milestone
backlog to the fu...

Comments

@virtualtam
Copy link
Member

Follow-up to #333 - Refactor HTTP / Url functions
Relates to #324 - Memo: code refactoring

Todolist

Miscellaneous

  • Add an error page template & Router entry
    • Display UID / GID information - see POSIX functions

Shaarli update checks

PHP version checks

Setup/install form

  • Add a page / template for the install form
  • Move the timezone form to a template

Read/write permissions, file/folder ownership
@virtualtam virtualtam added enhancement cleanup code cleanup and refactoring labels Nov 9, 2015
@virtualtam virtualtam self-assigned this Nov 9, 2015
@virtualtam virtualtam added this to the 0.6.1 milestone Nov 9, 2015
This was referenced Nov 9, 2015
Closed
Closed
Closed
@virtualtam virtualtam changed the title Introduce a Shaarli class to group install/compatibility/update checks Introduce an ApplicationUtils class to group Shaarli (application) utils Nov 17, 2015
This was referenced Nov 22, 2015
Merged
Merged
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Nov 24, 2015
@virtualtam
install: check file/directory permissions for Shaarli resources
2e28269 
Relates to shaarli#40
Relates to shaarli#372

Additions:
 - FileUtils: IOException
 - ApplicationUtils:
   - check if Shaarli resources are accessible with sufficient permissions
   - basic test coverage
 - index.php:
   - check access permissions and redirect to an error page if needed:
     - before running the first installation

Modifications:
 - LinkDB:
   - factorize datastore write code
   - check if the datastore
     (exists AND is writeable) OR (doesn't exist AND its parent dir is writable)
   - raise an IOException if needed

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Nov 24, 2015
@virtualtam
application: move checkPHPVersion from Utils to ApplicationUtils
4e9469f 
Relates to shaarli#372

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
@virtualtam virtualtam mentioned this issue Nov 24, 2015
Merged
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Nov 24, 2015
@virtualtam
application: move checkPHPVersion from Utils to ApplicationUtils
c9cf271 
Relates to shaarli#372

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Nov 24, 2015
@virtualtam
application: refactor version checks, move to ApplicationUtils
e96d107 
Relates to shaarli#372

Modifications:
 - move checkUpdate() to ApplicationUtils
 - add/format code comments

TODO:
 - apply coding conventions
 - improve test coverage
 - simplify checks:
   - reduce file I/O operations
   - add return statements

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
@virtualtam virtualtam mentioned this issue Nov 24, 2015
Merged
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Nov 26, 2015
@virtualtam
application: refactor version checks, move to ApplicationUtils
7793c9d 
Relates to shaarli#372

Modifications:
 - move checkUpdate() to ApplicationUtils
 - apply coding conventions, simplify logic
 - add test coverage

TODO:
 - improve test coverage
 - simplify checks:
   - reduce file I/O operations
   - add return statements

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Nov 26, 2015
@virtualtam
application: refactor version checks, move to ApplicationUtils
8a76d00 
Relates to shaarli#372

Modifications:
 - move checkUpdate() to ApplicationUtils
 - apply coding conventions, simplify logic
 - add test coverage

Tools:
 - create a sandbox directory for tests

TODO:
 - simplify checks:
   - reduce file I/O operations
   - add return statements

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Nov 26, 2015
@virtualtam
application: refactor version checks, move to ApplicationUtils
288fb1c 
Relates to shaarli#372

Modifications:
 - move checkUpdate() to ApplicationUtils
 - reduce file I/O operations during version checks
 - apply coding conventions
 - add test coverage

Tools:
 - create a sandbox directory for tests

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Nov 26, 2015
@virtualtam
application: refactor version checks, move to ApplicationUtils
847886b 
Relates to shaarli#372

Modifications:
 - move checkUpdate() to ApplicationUtils
 - reduce file I/O operations during version checks
 - apply coding conventions
 - add test coverage

Tools:
 - create a sandbox directory for tests

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Nov 26, 2015
@virtualtam
application: refactor version checks, move to ApplicationUtils
05f9795 
Relates to shaarli#372

Modifications:
 - move checkUpdate() to ApplicationUtils
 - reduce file I/O operations during version checks
 - apply coding conventions
 - add test coverage

Tools:
 - create a sandbox directory for tests

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Nov 26, 2015
@virtualtam
application: refactor version checks, move to ApplicationUtils
6c487af 
Relates to shaarli#372

Modifications:
 - move checkUpdate() to ApplicationUtils
 - reduce file I/O operations during version checks
 - apply coding conventions
 - add test coverage

Tools:
 - create a sandbox directory for tests

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Nov 26, 2015
@virtualtam
application: refactor version checks, move to ApplicationUtils
4bf35ba 
Relates to shaarli#372

Modifications:
 - move checkUpdate() to ApplicationUtils
 - reduce file I/O operations during version checks
 - apply coding conventions
 - add test coverage

Tools:
 - create a sandbox directory for tests

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Nov 26, 2015
@virtualtam
application: default to the "stable" branch for update checks
4407b45 
Relates to shaarli#372
Relates to shaarli#390

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
@virtualtam virtualtam mentioned this issue Nov 26, 2015
Merged
@virtualtam virtualtam modified the milestones: 0.6.2, 0.6.1 Nov 30, 2015
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Dec 1, 2015
@virtualtam
application: rework the installation form
6af6a36 
Relates to shaarli#372

Modifications:
 - HTML template
   - use a form fieldset layout + minimal CSS
   - do not include Shaarli headers & footers

TODO:
 - HTML template
   - generate a timezone fieldset
 - ApplicationUtils
   - assimilate the `install()` function
   - assimilate the timezone functions
   - timezone: defer HTML/form generation to HTML templates
   - apply coding conventions
   - add test coverage when possible/relevant

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Dec 1, 2015
@virtualtam
application: rework the installation form generation
9aad796 
Relates to shaarli#372

Modifications:
 - HTML template
   - use a form fieldset layout + minimal CSS
   - do not include Shaarli headers & footers

TODO:
 - HTML template
   - generate a timezone fieldset
 - ApplicationUtils
   - assimilate the `install()` function
   - assimilate the timezone functions
   - timezone: defer HTML/form generation to HTML templates
   - apply coding conventions
   - add test coverage when possible/relevant

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
@virtualtam virtualtam mentioned this issue Dec 1, 2015
Closed
2 tasks
@ArthurHoaro ArthurHoaro modified the milestones: 0.7.0, 0.7.1 May 14, 2016
@virtualtam virtualtam modified the milestones: 0.9.0, 0.8.0 Jul 23, 2016
@ArthurHoaro ArthurHoaro mentioned this issue Aug 8, 2016
Closed
@ArthurHoaro ArthurHoaro modified the milestones: 0.9.0, 0.9.1 Jan 25, 2017
@virtualtam virtualtam modified the milestones: 0.10.0, 0.9.1 Jul 29, 2017
@virtualtam virtualtam mentioned this issue Apr 1, 2018
Merged
@virtualtam virtualtam modified the milestones: 0.10.0, 0.10.1 Apr 27, 2018
@ArthurHoaro ArthurHoaro modified the milestones: 0.10.1, 0.10.2 Jul 29, 2018
@ArthurHoaro ArthurHoaro modified the milestones: 0.10.2, 0.10.3 Aug 11, 2018
@virtualtam virtualtam modified the milestones: 0.10.3, 0.11.0 Feb 23, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.11.0, 0.11.1 Jul 27, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.11.1, 0.11.2 Aug 7, 2019
@ArthurHoaro ArthurHoaro removed this from the 0.12.0 milestone Sep 12, 2020
@nodiscc nodiscc added this to the backlog to the future milestone Sep 12, 2020
@virtualtam
Copy link
Member Author

virtualtam commented Jun 5, 2022 •
edited
Loading

Closing as stale / obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@virtualtam virtualtam

Labels
cleanup code cleanup and refactoring enhancement
Projects
None yet
Milestone
backlog to the future
Development

No branches or pull requests
3 participants
@virtualtam @ArthurHoaro @nodiscc