Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application: default to the "stable" branch for update checks #394

Merged

Conversation

virtualtam
Copy link
Member

Relates to #372
Relates to #390

Relates to shaarli#372
Relates to shaarli#390

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
@virtualtam virtualtam self-assigned this Nov 26, 2015
@virtualtam virtualtam added this to the 0.6.1 milestone Nov 26, 2015
virtualtam added a commit that referenced this pull request Nov 30, 2015
…-branch

application: default to the "stable" branch for update checks
@virtualtam virtualtam merged commit 05f21ea into shaarli:master Nov 30, 2015
@virtualtam virtualtam deleted the app-utils/check-update/stable-branch branch November 30, 2015 01:06
@ArthurHoaro
Copy link
Member

I've got an exception with this.

PHP Notice: Undefined variable: versionError in [compiled footer].

I believe it's because the variable is optionally assign (doesn't exist), and your if translates as:

<?php if( $versionError ){ ?>

@virtualtam
Copy link
Member Author

Argh! I'll submit a fix to initialize the variables to an empty value to ensure they can be evaluated in templates

virtualtam added a commit to virtualtam/Shaarli that referenced this pull request Dec 3, 2015
Regression introduced in shaarli#394

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants