stack navigator and search screen #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, as an exported enum. Use hex where possible.
… On 18 Sep 2020, at 14:56, ਸਹਜਪ੍ਰੀਤ ਸਿੰਘ ***@***.***> wrote:
@saihaj commented on this pull request.
In src/components/Search.tsx:
> flexDirection: 'row',
+ borderRadius: 10,
+ backgroundColor: 'rgb(220,219,224)',
For now should I move this to a src/theme/colors.js?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
saihaj
force-pushed
the
styleSearchScreen
branch
from
ae38b64 to
8545b61
Compare
react-native-safe-area context adds to much and we lose control over changing color of status bar. Check slack thread for screenshots https://shabados.slack.com/archives/CD41G8413/p1600273582403700 Resource: https://stackoverflow.com/a/52458846/11321732
Harjot1Singh
requested changes
Sep 18, 2020
| @@ -21,10 +31,10 @@ type SearchBarProps = { | |||
|
|
|||
| const SearchBar = ( { handleTextChanges }: SearchBarProps ) => ( | |||
| <View style={styles.searchBar}> | |||
| <Icon name="magnify" size={25} /> | |||
| <Icon name="magnify" size={25} style={styles.centered} /> | |||
| <TextInput | |||
| placeholder="Koj" | |||
There was a problem hiding this comment.
@bhajneet do we want to bake in internationalisation from the start? This would be an example of where to start.
There was a problem hiding this comment.
Yes absolutely, how can I help?
There was a problem hiding this comment.
I think search screen cannot be a candidate yet since we will only support Punjabi search. Having that screen internationalized won’t make much sense unless we figure out how to convert search into languages we support with internationalization.
There was a problem hiding this comment.
The placeholder can be "Search" or "Khoj" or whatever language is chosen.
…t bottom Co-authored-by: Harjot Singh <contact@harjot.me>
Co-authored-by: Harjot Singh <contact@harjot.me>
Harjot1Singh
requested changes
Sep 22, 2020
saihaj
commented
Sep 22, 2020
Harjot1Singh
requested changes
Sep 24, 2020
https: //github.com/conventional-changelog/commitlint/tree/master/@commitlint/config-conventional#body-max-line-length Co-Authored-By: Harjot Singh <contact@harjot.me>
Harjot1Singh
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR
Time spent on PR
6 hours
Linked issues
Building block PR for #98 and eventually #96
Reviewers
@Harjot1Singh