feat: add basic search bar for search screen #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase and let me know what the status is of this PR |
|
Need to get #117 merged before I get back to this so putting it on hold |
saihaj
added
Effort 5
Harjot1Singh
requested changes
Dec 27, 2020
saihaj
added a commit
to saihaj/ShabadOSmobile
that referenced
this pull request
Dec 27, 2020
Suggested in PR review shabados#96 (comment) Co-Authored-By: Harjot Singh <contact@harjot.me>
It was a typo since mx should mean changing left to right and not top and bottom same applies for padding
saihaj
added a commit
to saihaj/ShabadOSmobile
that referenced
this pull request
Dec 28, 2020
Suggested in PR review shabados#96 (comment) Co-Authored-By: Harjot Singh <contact@harjot.me>
saihaj
changed the title
Harjot1Singh
requested changes
Dec 29, 2020
length should be greater than 0 Co-authored-by: Harjot Singh <harjot@harkul.com>
Harjot1Singh
requested changes
Dec 30, 2020
Harjot1Singh
approved these changes
Dec 30, 2020
Harjot1Singh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR
Implement Search Bar component as defined in #95
iOS Preview
Android Preview
Time spent on PR
nine_thousand_years
Linked issues
Related #95
Reviewers
@Harjot1Singh @bhajneet