Skip to content

Commit

Permalink
Disable lots of crashing compute tests for 'wgpu'
Browse files Browse the repository at this point in the history
This closes issue #5051.
  • Loading branch information
aleino-nv committed Oct 2, 2024
1 parent 46ff5d9 commit 418d39f
Show file tree
Hide file tree
Showing 15 changed files with 45 additions and 0 deletions.
1 change: 1 addition & 0 deletions tests/compute/atomics-buffer.slang
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
// RWBuffer does not work with the GFX backend as expected with Metal
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl
//TEST:SIMPLE(filecheck=METALLIB): -target metallib -stage compute -entry computeMain
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -wgpu

//METALLIB: @computeMain

Expand Down
1 change: 1 addition & 0 deletions tests/compute/atomics-groupshared.slang
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
//TEST(compute):COMPARE_COMPUTE_EX:-slang -compute -vk -shaderobj
//TEST(compute):COMPARE_COMPUTE_EX:-slang -compute -cuda -shaderobj
//TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -wgpu

//TEST_INPUT:ubuffer(data=[0 0 0 0], stride=4):out,name outputBuffer

Expand Down
1 change: 1 addition & 0 deletions tests/compute/atomics.slang
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
//TEST(compute):COMPARE_COMPUTE_EX:-slang -compute -vk -shaderobj
//TEST(compute):COMPARE_COMPUTE_EX:-slang -compute -cuda -shaderobj
//TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -wgpu

//TEST_INPUT:ubuffer(data=[0 0 0 0], stride=4):out, name outputBuffer

Expand Down
1 change: 1 addition & 0 deletions tests/compute/buffer-type-splitting.slang
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
//TEST(compute):COMPARE_COMPUTE:-cpu
//TEST(compute):COMPARE_COMPUTE: -shaderobj
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -wgpu

//TEST_INPUT:ubuffer(data=[0 0 0 0], stride=4):out,name=outputBuffer
//TEST_INPUT:ubuffer(data=[0 2 3 3]):name=s[0].a
Expand Down
1 change: 1 addition & 0 deletions tests/compute/byte-address-buffer.slang
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
//TEST(compute):COMPARE_COMPUTE_EX:-slang -compute -shaderobj
//TEST(compute, vulkan):COMPARE_COMPUTE_EX:-vk -compute -shaderobj
//TEST(compute):COMPARE_COMPUTE_EX:-d3d12 -compute -shaderobj
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -wgpu

// Confirm cross-compilation of `(RW)ByteAddressBuffer`
//
Expand Down
1 change: 1 addition & 0 deletions tests/compute/column-major.slang
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
//TEST(compute, vulkan):COMPARE_COMPUTE_EX(filecheck-buffer=BUF):-vk -compute -emit-spirv-via-glsl -Xslang -matrix-layout-column-major
//TEST(compute):COMPARE_COMPUTE_EX(filecheck-buffer=BUF):-cuda -compute -shaderobj -Xslang -matrix-layout-column-major
//TEST(compute):COMPARE_COMPUTE_EX(filecheck-buffer=BUF):-mtl -compute -shaderobj -Xslang -matrix-layout-column-major
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -wgpu

// This data is in column major layout order....
//TEST_INPUT:cbuffer(data=[1.0 0.0 0.0 10.0 0.0 1.0 0.0 20.0 0.0 0.0 1.0 30.0 0.0 0.0 0.0 1.0]):name matrixBuffer
Expand Down
2 changes: 2 additions & 0 deletions tests/compute/constant-buffer-memory-packing.slang
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
//TEST(compute, vulkan):COMPARE_COMPUTE_EX(filecheck-buffer=BUF):-vk -compute
//TEST(compute):COMPARE_COMPUTE_EX(filecheck-buffer=BUF):-mtl -compute

//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -wgpu

// CPP/CUDA due to natural layout rules will recieve the following ROW matrix:
// {1,2,3}
// {0,4,5}
Expand Down
1 change: 1 addition & 0 deletions tests/compute/func-cbuffer-param.slang
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
//TEST(compute, vulkan, compatibility-issue):COMPARE_COMPUTE_EX:-dx12 -compute -use-dxil -shaderobj
//TEST(compute, vulkan):COMPARE_COMPUTE_EX:-vk -compute -shaderobj
//TEST(compute, vulkan):COMPARE_COMPUTE_EX:-cpu -compute -shaderobj
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -wgpu

struct Data
{
Expand Down
1 change: 1 addition & 0 deletions tests/compute/parameter-block.slang
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
//TEST(compute):COMPARE_COMPUTE:-vk -shaderobj
//TEST(compute):COMPARE_COMPUTE:-shaderobj
//TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl -render-features argument-buffer-tier-2
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -wgpu

// Ensure that Slang `ParameterBlock` type is lowered
// to HLSL in the fashion that we expect.
Expand Down
1 change: 1 addition & 0 deletions tests/compute/texture-get-dimensions.slang
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
//DISABLE_TEST(compute, vulkan):COMPARE_COMPUTE_EX:-vk -compute -shaderobj
// TODO(JS): Doesn't work on CUDA as there aren't any CUDA functions to get dimensions.
//DISABLE_TEST(compute):COMPARE_COMPUTE_EX:-cuda -compute -shaderobj
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -wgpu

//TEST_INPUT: Texture1D(size=4, content = one):name t1D
Texture1D<float> t1D;
Expand Down
1 change: 1 addition & 0 deletions tests/compute/texture-sampling.slang
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
//TEST_INPUT: TextureCube(size=4, content = one, arrayLength=2):name=tCubeArray
//TEST_INPUT: Sampler:name=samplerState
//TEST_INPUT: ubuffer(data=[0 0 0 0], stride=4):out,name=outputBuffer
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -wgpu

Texture1D t1D;
Texture2D t2D;
Expand Down
2 changes: 2 additions & 0 deletions tests/compute/texture-simple.slang
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
//DISABLE_TEST_INPUT: Texture1D(format=R_Float32, size=4, content = one, mipMaps=1):name tLoad1D
//Texture1D<float> tLoad1D;

//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -wgpu

//TEST_INPUT: Texture1D(size=4, content = one):name t1D
Texture1D<float> t1D;
//TEST_INPUT: Texture2D(size=4, content = one):name t2D
Expand Down
1 change: 1 addition & 0 deletions tests/compute/texture-simpler.slang
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
//TEST(smoke,compute, vulkan):COMPARE_COMPUTE_EX:-vk -compute -shaderobj -output-using-type -render-feature hardware-device
//TEST(smoke,compute):COMPARE_COMPUTE_EX:-cuda -compute -shaderobj -output-using-type
//TEST(smoke,compute):COMPARE_COMPUTE:-slang -shaderobj -mtl -output-using-type
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -wgpu

//TEST_INPUT: Texture2D(size=4, content = one):name t2D
Texture2D<float> t2D;
Expand Down
1 change: 1 addition & 0 deletions tests/compute/transcendental-double.slang
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
// When using double on vulkan the values are incorrect(!)
//DISABLE_TEST(compute,vulkan):COMPARE_COMPUTE:-vk -output-using-type -shaderobj
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -mtl
//DISABLE_TEST(compute):COMPARE_COMPUTE:-slang -shaderobj -wgpu

//TEST_INPUT:ubuffer(data=[0 0 0 0 0 0 0 0], stride=4):out,name=outputBuffer
RWStructuredBuffer<float> outputBuffer;
Expand Down
29 changes: 29 additions & 0 deletions tests/expected-failure-github.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,32 @@ tests/language-feature/saturated-cooperation/fuse-product.slang (vk)
tests/language-feature/saturated-cooperation/fuse.slang (vk)
tests/bugs/byte-address-buffer-interlocked-add-f32.slang (vk)
tests/serialization/obfuscated-serialized-module-test.slang.2 syn (mtl)
tests/compute/atomics (wgpu)
tests/compute/atomics-buffer (wgpu)
tests/compute/atomics-groupshared (wgpu)
tests/compute/buffer-type-splitting (wgpu)
tests/compute/byte-address-buffer (wgpu)
tests/compute/cbuffer-legalize.slang.2 syn (wgpu)
tests/compute/column-major (wgpu)
tests/compute/compile-time-loop.slang.2 syn (wgpu)
tests/compute/constant-buffer-memory-packing (wgpu)
tests/compute/constexpr.slang.2 syn (wgpu)
tests/compute/discard-stmt.slang.2 syn (wgpu)
tests/compute/func-cbuffer-param (wgpu)
tests/compute/func-param-legalize.slang.1 syn (wgpu)
tests/compute/func-resource-param.slang.4 syn (wgpu)
tests/compute/global-init.slang.2 syn (wgpu)
tests/compute/interface-shader-param-in-struct.slang.4 syn (wgpu)
tests/compute/interface-shader-param.slang.5 syn (wgpu)
tests/compute/kernel-context-threading.slang.6 syn (wgpu)
tests/compute/loop-unroll.slang.7 syn (wgpu)
tests/compute/matrix-layout.hlsl.3 syn (wgpu)
tests/compute/non-square-column-major.slang.6 syn (wgpu)
tests/compute/non-square-row-major.slang.6 syn (wgpu)
tests/compute/parameter-block (wgpu)
tests/compute/row-major.slang.4 syn (wgpu)
tests/compute/texture-get-dimensions (wgpu)
tests/compute/texture-sampling (wgpu)
tests/compute/texture-simple (wgpu)
tests/compute/texture-simpler (wgpu)
tests/compute/transcendental-double (wgpu)

0 comments on commit 418d39f

Please sign in to comment.