Skip to content

Commit

Permalink
Add path to bash to GITHUB_PATH (#5217)
Browse files Browse the repository at this point in the history
* Add path to bash to GITHUB_PATH

This is a workaround for a problem that keeps reoccurring on one of our self-hosted machines.
Ideally, we should assume that bash shell is available on the runner system, and we should rely on the system-wise setting of PATH to find bash.

This commit is a workaround for a case where bash cannot be found from the runner machine, which shouldn't be a case in a normal situation. It is also not safe to assume that the location of where bash is at a fixed location, because it can vary by how the system is setup.
Once we root cause the issue on the SlangWin4-2, we may remove this workaround later.
  • Loading branch information
jkwak-work authored Oct 3, 2024
1 parent a11a776 commit 74bdd03
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .github/actions/common-setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ inputs:
runs:
using: composite
steps:
- name: Add bash to PATH
shell: pwsh
if: ${{inputs.os == 'windows'}}
run: |
Add-Content -Path $env:GITHUB_PATH -Value "C:\\Program Files\\Git\\bin"
Add-Content -Path $env:GITHUB_PATH -Value "C:\\Program Files\\Git\\usr\\bin"
- name: Set up MSVC dev tools on Windows
uses: ilammy/msvc-dev-cmd@v1
with:
Expand Down

0 comments on commit 74bdd03

Please sign in to comment.