Slang-test compute-derivative fails with SPIRV-Headers upgrade #5106
Assignees
Labels
goal:quality & productivity
Quality issues and issues that impact our productivity coding day to day inside slang
kind:bug
something doesn't work like it should
Milestone
Comments
cheneym2
changed the title
|
In each of the failing tests, replacing the CHECK string from the NV named extension to KHR makes the issue go away. |
cheneym2
added a commit
to cheneym2/slang
that referenced
this issue
Sep 18, 2024
Extension was promoted from NV to KHR while retaining same enums. Fixes shader-slang#5106
cheneym2
added a commit
to cheneym2/slang
that referenced
this issue
Sep 18, 2024
Add fixes for a missing test intrinsic-derivative-function-in-compute.slang
Use the {{NV|KHR}} syntax to tolerate either enum.
Fixes shader-slang#5106
jkwak-work
added
kind:regression
kind:bug
bmillsNV
added
the
goal:quality & productivity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The regression occurs with SPIRV-Headers change:
2a9b6f951c7d6b04b6c21fe1bf3f475b68b84801 Add Capability and Execution mode SPV_KHR_compute_shader_derivatives (#446)
Failing tests:
tests/glsl-intrinsic/compute-derivative/derivative-mode-undefined-mode2.slang
tests/glsl-intrinsic/compute-derivative/derivative-mode-many-entry-points2.slang
tests/glsl-intrinsic/compute-derivative/derivative-mode-undefined-mode3.slang
tests/glsl-intrinsic/compute-derivative/derivative-mode-many-entry-points1.slang
tests/glsl-intrinsic/compute-derivative/derivative-mode-undefined-mode.slang
tests/glsl-intrinsic/compute-derivative/derivative-mode-many-entry-points3.slang
Supported backends: glslang spirv-dis gcc genericcpp llvm spirv-opt
error: slang-test: tests/glsl-intrinsic/compute-derivative/derivative-mode-undefined-mode.slang:2:22: error: CHECK_SPV_SYNTAX: expected string not found in input
// CHECK_SPV_SYNTAX: DerivativeGroupQuadsNV
^
error: slang-test: actual-output:1:1: note: scanning from here
result code = 0
^
error: slang-test: actual-output:10:21: note: possible intended match here
OpCapability ComputeDerivativeGroupQuadsKHR
^
FAILED test: 'tests/glsl-intrinsic/compute-derivative/derivative-mode-undefined-mode.slang'
passed test: 'tests/glsl-intrinsic/compute-derivative/derivative-mode-undefined-mode.slang.1'
===
71% of tests passed (23/32)
failing tests:
tests/glsl-intrinsic/compute-derivative/derivative-mode-undefined-mode2.slang
tests/glsl-intrinsic/compute-derivative/derivative-mode-undefined-mode.slang
tests/glsl-intrinsic/compute-derivative/derivative-mode-undefined-mode3.slang
tests/glsl-intrinsic/compute-derivative/derivative-mode-many-entry-points1.slang
tests/glsl-intrinsic/compute-derivative/derivative-mode-many-entry-points1.slang.1
tests/glsl-intrinsic/compute-derivative/derivative-mode-many-entry-points3.slang
tests/glsl-intrinsic/compute-derivative/derivative-mode-many-entry-points2.slang
tests/glsl-intrinsic/compute-derivative/intrinsic-derivative-function-in-compute.slang.2
tests/glsl-intrinsic/compute-derivative/intrinsic-derivative-function-in-compute.slang.3
The text was updated successfully, but these errors were encountered: