Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't build slang-llvm in CI when targeting wasm platform #5195

Closed
jkwak-work opened this issue Sep 30, 2024 · 0 comments · Fixed by #5196
Closed

Don't build slang-llvm in CI when targeting wasm platform #5195

jkwak-work opened this issue Sep 30, 2024 · 0 comments · Fixed by #5196
Assignees
@jkwak-work
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang

Comments

@jkwak-work
Copy link
Collaborator

PR #5164 added a new platform target, "wasm", for building WebAseembly build of Slang.
It is expected to take about 7 minutes but when the sccache fail to work, the build time goes above 30 minutes.
Most of the build time is spent for building slang-llvm locally, and slang-llvm is not needed for WebAssembly at the moment.
We should avoid building slang-llvm when targeting wasm platform in the ci workflow.
@jkwak-work jkwak-work added the goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang label Sep 30, 2024
@jkwak-work jkwak-work self-assigned this Sep 30, 2024
@jkwak-work jkwak-work mentioned this issue Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkwak-work jkwak-work

Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable the building of slang-llvm when targeting wasm platform jkwak-work/slang
1 participant
@jkwak-work