Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI step to build WebAssembly version of Slang #5164

Merged

Conversation

jkwak-work
Copy link
Collaborator

@jkwak-work jkwak-work commented Sep 26, 2024

Closes #5117

This adds a build step of WebAssembly version of Slang for all platforms and all configurations.
The new build step appears to take about double times of time compared to the regular Slang build step.

@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Sep 26, 2024
@jkwak-work jkwak-work self-assigned this Sep 26, 2024
@jkwak-work jkwak-work force-pushed the feature/workflow_include_wasm_build branch 2 times, most recently from 659e437 to 08942e9 Compare September 26, 2024 22:25
@jkwak-work jkwak-work changed the title WIP: Add CI step to build WebAssembly version of Slang Add CI step to build WebAssembly version of Slang Sep 26, 2024
@jkwak-work jkwak-work marked this pull request as ready for review September 26, 2024 22:25
.github/workflows/ci.yml Outdated Show resolved Hide resolved
aleino-nv
aleino-nv previously approved these changes Sep 27, 2024
csyonghe
csyonghe previously approved these changes Sep 27, 2024
Closes shader-slang#5117

This adds a build step of WebAssembly version of Slang.
Currently it is enabled only for Linux/Release to reduce the time cost
of CI, but the builds were all successful on all platforms and
configurations when tested.
@jkwak-work jkwak-work force-pushed the feature/workflow_include_wasm_build branch from 87b68c1 to d26e779 Compare September 27, 2024 22:25
@jkwak-work jkwak-work merged commit f667593 into shader-slang:master Sep 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wasm build: Integrate to CI
3 participants