Migrate examples #4920
Merged
Migrate examples #4920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate cpu-hello-world to new slang API, and also convert this example as one of the unit test. Fix some bugs in replayer: - Wrong decode type in 'getEntryPointHostCallable'. - Mistakes in computing the output buffer size. Improve json consumer on the prelude text.
Convert 'shader-object' to record-replay test and add it to slang-unit-test group. Fix some replay bugs: - Wrong decode type in array size in specialize() call.
Convert ray-tracing example into unit-test Add ray-tracing into slang-unit-test Fix the memory management issue in the record layer - When capture entrypoint, we should increase the reference count for the allocated entrypoint recorder object, because that is allocated by record layer, it should be owned by the layer, user should not be able to free it. In our test, we add a "callIdx" string at beginning of the hash-code string, as there could be more than one modules in the example, so they could call 'getEntryPointHash' multiple times, in order for the test can identify them, add "callIdx: <number>" as the key word.
|
PR for issue #4570. |
csyonghe
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate cpu-hello-world to new slang API and add it to slang-unit-test
Add 'shader-object' to slang-unit-test
Convert ray-tracing example into slang-unit-test
Fix bugs in record-replay layer:
for the allocated entrypoint recorder object, because that is
allocated by record layer, it should be owned by the layer, user
should not be able to free it.