Add Path::removeNonEmpty() to remove non-empty dir #4984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizhangNV
force-pushed
the
remove-dir-recursive
branch
from
ba7c179
to
9cb15d3
Compare
kaizhangNV
force-pushed
the
remove-dir-recursive
branch
2 times, most recently
from
784a707
to
a3f010a
Compare
ArielG-NV
reviewed
Sep 3, 2024
ArielG-NV
reviewed
Sep 3, 2024
kaizhangNV
force-pushed
the
remove-dir-recursive
branch
from
a3f010a
to
ac27dab
Compare
We've implemented a function in slang-record-replay unit test to remove the non-empty directory, now move this function into slang `Path` namespace to make this function as an utility. Close issue shader-slang#4916
kaizhangNV
force-pushed
the
remove-dir-recursive
branch
from
ac27dab
to
5b53aac
Compare
csyonghe
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've implemented a function in slang-record-replay unit test to remove the non-empty directory, now move this function into slang
Pathnamespace to make this function as an utility.Close issue #4916