Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct control flow in getParentBreakBlockSet #5024

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Correct control flow in getParentBreakBlockSet #5024

merged 3 commits into from
Sep 6, 2024

Conversation

expipiplus1
Copy link
Collaborator

No description provided.

@expipiplus1 expipiplus1 added the pr: non-breaking PRs without breaking changes label Sep 6, 2024
ArielG-NV
ArielG-NV approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@ArielG-NV ArielG-NV left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Note:
Example program to show why this change is needed

#include<stdio.h>
#include<cstdint>
int main()
{
    if(1 == 2)
        if(2 == 2)
            printf("1");
    else if (1 == 1)
        if (2 == 2)
            printf("2");
}
// Nothing will be printed

@csyonghe csyonghe merged commit 69ee8f6 into shader-slang:master Sep 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csyonghe csyonghe csyonghe approved these changes

@ArielG-NV ArielG-NV ArielG-NV approved these changes

Assignees
No one assigned
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@expipiplus1 @csyonghe @ArielG-NV