Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GITHUB_TOKEN if set #5070

Merged

Commits on Sep 16, 2024

  1. Use GITHUB_TOKEN if set

    We have been having an error from Github saying that API rate limit
    exceeded for IP. It hits the limit more often if your public IP is
    shared by many other collegues.
    
    {"message":"API rate limit exceeded for 216.228.112.22. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}
    
    The suggested solution from GitHub is to use gh.exe tool with "auth
    login" arguments. It will store a token and allow us to use API more
    than the limit set for IP without token.
    
    However, our cmake build doesn't use gh.exe and API is called via REST.
    This commit adds an extra header to the HTTP request with the
    infomration of the github token if the value is.
    
    Usage: cmake.exe --preset vs2019 -DSLANG_GITHUB_TOKEN=your_token_here
    jkwak-work committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ee95268 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    4f307df View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Configuration menu
    Copy the full SHA
    ddc4754 View commit details
    Browse the repository at this point in the history