Implement math intrinsics for WGSL #5078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csyonghe
reviewed
Sep 17, 2024
|
Many CI actions are failing but they don't seem to be related to my change, because they seem to be failing to checkout from github repository. I will re-trigger the failed tests later and see if it works out. |
|
@jkwak-work any idea on the failed CI runs? |
I am still investigating. |
|
It turned out that the CI failures are due to my change. slang/tools/slang-test/slang-test-main.cpp Line 957 in 25d1559 The target, SLANG_WGSL, was not handled in this function. |
This commit implements math related intrinsics and a few others for WGSL. The implementation is based on the following doc, https://www.w3.org/TR/WGSL
slang-test was looking for the downstream compiler for WGSL even though it is not used. This commit adds a minimal change to avoid the crash.
jkwak-work
force-pushed
the
feature/add_wgsl_intrinsics
branch
from
2994aac
to
5f103c6
Compare
|
All CI are now passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements math related intrinsics and a few others for WGSL.
The implementation is based on the following doc,
https://www.w3.org/TR/WGSL