Add WGSL intrinsics for synchronization #5114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@csyonghe I'm a bit unsure about how the WGSL memory model maps to Slang/HLSL. Does Slang adopt HLSL's memory model? |
|
Slang currently has no official memory model. The behavior around atomics and synchronization is mostly target dependent right now. HLSL is also kind of loose in the front in that there isn't a clear spec on what the memory model is there. |
csyonghe
approved these changes
Sep 19, 2024
|
Please use "Closes #5085" in the description, so that issue can automatically be closed by github when this PR lands. |
aleino-nv
force-pushed
the
aleino/wgsl-intrinsics
branch
from
b44aac9
to
e426f73
Compare
Ok I changed "addresses" to "closes". |
This closes issue shader-slang#5085.
aleino-nv
force-pushed
the
aleino/wgsl-intrinsics
branch
from
e426f73
to
7fb99a8
Compare
jkwak-work
reviewed
Sep 19, 2024
| @@ -7553,11 +7555,12 @@ void DeviceMemoryBarrier() | |||
| { | |||
| OpMemoryBarrier Device AcquireRelease|UniformMemory|ImageMemory; | |||
| }; | |||
| case wgsl: __intrinsic_asm "storageBarrier(); textureBarrier(); workgroupBarrier();"; | |||
There was a problem hiding this comment.
Do we need workgroupBarrier here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #5085.