Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WGSL texture support for depth and multisampled #5152

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

jkwak-work
Copy link
Collaborator

@jkwak-work jkwak-work commented Sep 25, 2024

This commit fixes a few issues with WGSL texture intrinsics.

  • static_assert-s are corrected.
  • Gather functions work properly with depth textures
  • Load functions work properly with depth textures

@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Sep 25, 2024
@jkwak-work jkwak-work self-assigned this Sep 25, 2024
@jkwak-work jkwak-work changed the title Fix WGSL texture intrinsics WGSL texture support for depth and multisampled Sep 25, 2024
@jkwak-work
Copy link
Collaborator Author

I decided to make a separate PR for texture_storage_Xd changes.

@jkwak-work jkwak-work marked this pull request as ready for review September 25, 2024 05:58
csyonghe
csyonghe previously approved these changes Sep 25, 2024
This commit fixes a few issues with WGSL texture intrinsics.
 - static_assert-s are corrected.
 - Gather functions work properly with depth textures
 - Load functions work properly with depth textures and multisampled
   textures
@jkwak-work jkwak-work merged commit 03765a6 into shader-slang:master Sep 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants