Use Offset instead of ConstOffset for GLSL function textureGatherOffset #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwak-work
force-pushed
the
fix/incorrect_use_of_const_offset_on_spirv_OpImageGather
branch
from
3c1514d
to
69f949e
Compare
expipiplus1
previously approved these changes
Oct 29, 2024
This commit changes to use `Offset` option on OpImageGather instruction when translating `textureGatherOffset` to SPIR-V code. Interestingly GLSL allows the offset value to be a variable not constant just for the function `textureGatherOffset` while all other offset variants of texture sampling functions require the offset to be a constant value. From a few experiments, I found that the spirv-optimizer changes `Offset` to `ConstOffset` if the offset is a compile-time value. I also found that when the offset value is zero, it changes to `None` with no offset value.
jkwak-work
force-pushed
the
fix/incorrect_use_of_const_offset_on_spirv_OpImageGather
branch
from
534d8f6
to
44a7523
Compare
jkwak-work
deleted the
fix/incorrect_use_of_const_offset_on_spirv_OpImageGather
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5339
This commit changes to use
Offsetoption on OpImageGather instruction when translatingtextureGatherOffsetto SPIR-V code.Interestingly GLSL allows the offset value to be a variable not constant just for the function
textureGatherOffsetwhile all other offset variants of texture sampling functions require the offset to be a constant value.From a few experiments, I found that the spirv-optimizer changes
OffsettoConstOffsetif the offset is a compile-time value. I also found that when the offset value is zero, it changes toNonewith no offset value.