Various fixes to enable some WGSL graphics tests #5548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
aleino-nv
force-pushed
the
aleino/wgpu
branch
from
2333306
to
2f9cde7
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
aleino-nv
added a commit
to aleino-nv/slang
that referenced
this pull request
Nov 13, 2024
Format code for PR shader-slang#5548
There was a "kinds" vs. "kind flags" mismatch, and also getBindingOffsetForKinds was not being used. This patch enables a bunch of tests for WGPU. This helps to address issue shader-slang#4943.
aleino-nv
force-pushed
the
aleino/wgpu
branch
from
527eb1a
to
dc79b49
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
Format code for PR shader-slang#5548
csyonghe
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to address issue #4943