Insert some casts for WGSL texture attribute queries #5560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
aleino-nv
added a commit
to aleino-nv/slang
that referenced
this pull request
Nov 14, 2024
Format code for PR shader-slang#5560
aleino-nv
force-pushed
the
aleino/wgpu
branch
from
ddce250 to
260f427
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
aleino-nv
force-pushed
the
aleino/wgpu
branch
from
260f427 to
d7aa424
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
aleino-nv
added a commit
to aleino-nv/slang
that referenced
this pull request
Nov 14, 2024
Format code for PR shader-slang#5560
There are no 1d array textures in WGSL, so add texture-sampling-no-1d-arrays.slang based on texture-sampling.slang, but without 1d texture arrays. This helps to address issue shader-slang#4943.
This helps to address issue shader-slang#4943.
aleino-nv
force-pushed
the
aleino/wgpu
branch
from
5da6978 to
d07241a
Compare
csyonghe
approved these changes
Nov 14, 2024
csyonghe
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test is still disabled because there are some texture binding issues in Slang-RHI, still to be fixed.
This helps to address issue #4943.