Fix build error when SLANG_ENABLE_TESTS is set to OFF #6420
+25
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SLANG_ENABLE_TESTS is disabled but SLANG_ENABLE_GFX is enabled, cmake was failing. It turned out that gfx build target was trying to copy some of files to the directory where slang-test uses. When SLANG_ENABLE_TESTS is disabled, the directory information became unavailable, because slang-test target became unavailable. This commit makes the copying behavior conditional on SLANG_ENABLE_TESTS in the gfx build target.
|
/format |
…ithout_disabling_SLANG_ENABLE_GFX
|
🌈 Formatted, please merge the changes from this PR |
Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
…ithout_disabling_SLANG_ENABLE_GFX
…ithout_disabling_SLANG_ENABLE_GFX
|
@expipiplus1 , did you have a chance to review this yet? |
expipiplus1
approved these changes
Feb 24, 2025
…ithout_disabling_SLANG_ENABLE_GFX
…ithout_disabling_SLANG_ENABLE_GFX
…ithout_disabling_SLANG_ENABLE_GFX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SLANG_ENABLE_TESTS is disabled but SLANG_ENABLE_GFX is enabled, cmake was failing. It turned out that gfx build target was trying to copy some of files to the directory where slang-test uses. When SLANG_ENABLE_TESTS is disabled, the directory information became unavailable, because slang-test target became unavailable.
This commit makes the copying behavior conditional on SLANG_ENABLE_TESTS in the gfx build target.
Closes #6036
This PR is mostly done by github Copilot.