Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support addThumbnailsTrack in SRC_EQUALS #5778

Closed
absidue opened this issue Oct 17, 2023 · 5 comments · Fixed by #5802
Closed

Support addThumbnailsTrack in SRC_EQUALS #5778

absidue opened this issue Oct 17, 2023 · 5 comments · Fixed by #5802
Assignees
Labels
priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@absidue
Copy link

absidue commented Oct 17, 2023

Have you read the FAQ and checked for duplicate open issues?
Yes

Is your feature request related to a problem? Please describe.

Since version 4.4.0 (#5502) the UI will display thumbnails when hovering over the seek bar when they are provided. Unfortunately this is currently only usable when the load mode is MEDIA_SOURCE, as Player.addThumbnailsTrack() throws CANNOT_ADD_EXTERNAL_THUMBNAILS_TO_SRC_EQUALS when you call it when the load mode is SRC_EQUALS. While that error is correct, it also makes it impossible to use the thumbnail display feature with SRC_EQUALS.

Describe the solution you'd like

A way to pass thumbnail tracks to the UI even when the load mode is SRC_EQUALS. As shaka-player can handle them completely fine when the load mode is MEDIA_SOURCE, it means that most of the necessary infrastructure already exists, it just has to be adapted for use with the load mode being SRC_EQUALS.

Describe alternatives you've considered

Building a custom seek bar component with custom thumbnail handling and registering that with the UI.

@absidue absidue added the type: enhancement New feature or request label Oct 17, 2023
@shaka-bot shaka-bot added this to the Backlog milestone Oct 17, 2023
@theodab theodab added priority: P2 Smaller impact or easy workaround priority: P4 Nice to have / wishful thinking and removed priority: P2 Smaller impact or easy workaround labels Oct 19, 2023
@theodab
Copy link
Contributor

theodab commented Oct 19, 2023

Sure, that'd be possible. The thumbnails feature as it works today relies on the existence of a manifest, but there's no reason we couldn't add some alternate container for storing user-added image tracks that we could use while loaded in src-equals mode.

@avelad avelad self-assigned this Oct 19, 2023
@avelad
Copy link
Member

avelad commented Oct 19, 2023

I'll work on it in a few weeks.

@avelad avelad changed the title UI: Make it possible to use the seek bar thumbnails feature with SRC_EQUALS Support addThumbnailsTrack in SRC_EQUALS Oct 19, 2023
@avelad
Copy link
Member

avelad commented Oct 23, 2023

I'll work on this after it's merged #5752

@avelad
Copy link
Member

avelad commented Oct 24, 2023

@absidue I created #5778

@absidue
Copy link
Author

absidue commented Oct 24, 2023

Thank you! :)

avelad added a commit that referenced this issue Oct 26, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 25, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants